-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper function for go-sockaddr templating #1087
Add wrapper function for go-sockaddr templating #1087
Conversation
I think there may be a mistake in the vendoring here -- I don't think all of these are dependencies required by go-sockaddr. Can you review how you did the vendoring and double check you're only pulling in the necessary deps? |
Thanks for the contribution! |
412ef07
to
4b2d7e8
Compare
Thanks @pearkes for the heads up. I just did Anyway, I fixed the vendoring in this PR to just include Let me know if there's anything else we need to do before merging. |
will this get merged before the next release? I have an admittedly odd use case, specifically...but I would really, really enjoy having this in consul-template. |
Hey @vtorhonen, since you submitted your pull request we've implemented a policy of requiring a signed CLA before merging. Would you please consider signing the CLA? Thanks. |
4b2d7e8
to
5870f91
Compare
5870f91
to
ff2466d
Compare
@eikenb CLA signed and branch rebased. Sorry for the wait. :) |
@vtorhonen No problem. Thanks for doing that. I'm making one more bug sweep right now, but after I plan on reviewing all outstanding PRs to see what I can merge. I'll get to this then (think a couple weeks). Thanks. |
Hey @vtorhonen, reviewing all the PRs now and would like to ask if you could add a simple test in funcs_test.go for this. It won't be a blocker as this is such a simple function, but I've been asking all the other new functions for one and really would like to have better coverage of the functions directly (vs. going through the template rendering). Thanks. |
This PR bundles the many templating functionalities offered by hashicorp/go-sockaddr to consul-template. These template functionalities are especially useful in cases where consul-template is run upon system startup, for example by cloud-init, to render interface IP addresses to configuration files.
Also adds vendoring for
go-sockaddr
, which might make this PR look like a bit daunting (1,1M additions).Documentation updated as well.