Issue1198: error reading deleted secret #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
force-pushed
the
issue1198-err-reading-deleted-secret
branch
3 times, most recently
from
83d7b41 to
6afdc8a
Compare
eikenb
force-pushed
the
issue1198-err-reading-deleted-secret
branch
from
6afdc8a to
558a241
Compare
eikenb
force-pushed
the
issue1198-err-reading-deleted-secret
branch
from
f9b9c81 to
721243c
Compare
s-mang
approved these changes
Aug 19, 2019
eikenb
force-pushed
the
issue1198-err-reading-deleted-secret
branch
2 times, most recently
from
472675f to
1ea608b
Compare
When reading a deleted secret from vault, vault would return meta-data
and no data. The code wasn't setup to handle that and would error out
in the template with an "nil pointer evaluating interface {}" error.
This checks for that and returns the normal "no secret exists" error
that triggers the standard retrying behavior instead of exiting.
Fixes #1198
eikenb
force-pushed
the
issue1198-err-reading-deleted-secret
branch
from
1ea608b to
f52ffb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.