Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gnueabihf for 32-bit arm build #1326

Merged
merged 1 commit into from
Dec 16, 2019
Merged

use gnueabihf for 32-bit arm build #1326

merged 1 commit into from
Dec 16, 2019

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Dec 12, 2019

The 32 bit arm build that was supposed to work on both arm5 and arm6
won't run on systems without moving files around due to linking/naming
clashes. So we're changing the arm6 build to use
arm-linux-gnueabihf-gcc, which links against the expected libraries.

At this point we're just going to drop support for arm5 as I don't think
anyone is using it and it's starting to become obsolete.

Fixes #1317

The 32 bit arm build that was supposed to work on both arm5 and arm6
won't run on systems without moving files around due to linking/naming
clashes. So we're changing the arm6 build to use
arm-linux-gnueabihf-gcc, which links against the expected libraries.

At this point we're just going to drop support for arm5 as I don't think
anyone is using it and it's starting to become obsolete.

Fixes #1317
@eikenb eikenb added the bug label Dec 12, 2019
@eikenb eikenb requested a review from a team December 12, 2019 00:37
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eikenb, this makes sense! Would you be able to say more about ARM5 becoming obsolete just so I can better understand? Thanks!

@eikenb eikenb added this to the 0.23.1 milestone Dec 13, 2019
@eikenb
Copy link
Contributor Author

eikenb commented Dec 16, 2019

Arm5 was released in 2009 and is only used in very small embedded stuff these days, and not much of that. There are no ARM servers using it and even the small lab setups use newer CPUs. For example the oldest Raspberry-Pi, popular in small/home labs, used Arm-6.

@eikenb
Copy link
Contributor Author

eikenb commented Dec 16, 2019

@lornasong Or did you want more explanation in the commit message?

@lornasong
Copy link
Member

@eikenb - no need for more explanation in the commit message. Thanks for the information about Arm5! I just wanted to understand it a little bit better and had a hard time finding more information when searching. Helpful, thank you!

@eikenb eikenb merged commit 9245e2c into master Dec 16, 2019
@eikenb eikenb deleted the issue-1317-arm-build-fix branch December 16, 2019 22:33
eikenb added a commit that referenced this pull request Dec 18, 2019
Part of moving to use gnueabihf for arm6 build that I missed.
See GH-1326 for the rest of it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm builds are linked against wrong library
2 participants