fix data race b/w start and kill #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findkim
reviewed
Apr 23, 2020
eikenb
force-pushed
the
issue-1372-child-data-race
branch
4 times, most recently
from
e3043c7 to
bc473d3
Compare
Racing over saving and checking ProcessState. It was checking ProcessState to see if the command had exited. I tweaked exitCh to have closing it indicate that the command had exited.
findkim
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Racing over saving and checking ProcessState. It was checking
ProcessState to see if the command had exited. I tweaked exitCh
to have closing it indicate that the command had exited.
Fixes #1372