Add metrics reporting #1378
Merged
Add metrics reporting #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics will be configured in files and not through the CLI to avoid unnecessarily expanding the CLI options. Flush metrics on shutdown and configure dogstatsd reporting interval Add no-op provider Add documentation Add telemetry config tests Change instruments helper to accept nil meter
This allows metric collectors to distinguish the service metrics are reported on. Add dep type to dependencies received counter for more metadata on monitored changes to dependencies by type.
Status is more clear and uniform with the other metric labels.
eikenb
reviewed
May 11, 2020
eikenb
reviewed
May 11, 2020
eikenb
reviewed
May 11, 2020
The helper functions were initially added for completeness of config/convert.go in supporting the copy function for all of the supported types. However they remained unused and are now removed to keep the code trimmed and can be easily re-added when needed.
eikenb
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards adding support for Consul Template monitoring. The changes integrate with OpenTelemetry to add stdout, prometheus, and dogstatsd metric sinks. Metric configuration and metric sample outputs are added to the README documentation.
Things to consider when configuring telemetry:
Enhancement request #1078 to integrate OpenCensus received a number of community votes, and since it has been merged to become OpenTelemetry, we decided to choose the OpenTelemetry library. OpenTelemetry was chosen over armon/go-metrics, which has been commonly used in various HashiCorp projects, for Consul Template as an experiment towards a new library that has dedicated support to expand on new sinks and has tracing functionality. For a period of time, there may be a mismatch in supported sinks between Consul and Consul-Template, but we do hope to update this regularly as OpenTelemetry expands.
Resolves #1338, resolves #826, resolves #1078