Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows SC Service #1382

Closed
wants to merge 2 commits into from
Closed

Windows SC Service #1382

wants to merge 2 commits into from

Conversation

Vulfox
Copy link
Contributor

@Vulfox Vulfox commented May 13, 2020

This allows consul-template to be ran via Windows SC (Service Control) without the need of using nssm.exe.

The code is copy/paste from how consul and nomad implements the same feature.

@hashicorp-cla
Copy link

hashicorp-cla commented May 13, 2020

CLA assistant check
All committers have signed the CLA.

@MrWong99
Copy link
Contributor

MrWong99 commented Jun 4, 2020

Ran into the issue today when trying to setup a service on Win 10. Fix would be much appreciated 👍

I used a similar "sc create" command for consul and consul-template and only Consul worked as intended for ctemplate I got issue #1305

@MrWong99
Copy link
Contributor

MrWong99 commented Jun 5, 2020

Btw I successfully tested this enhancement on Windows 10 with v0.25.0 and only this PR merged.

@eikenb
Copy link
Contributor

eikenb commented Oct 16, 2020

Hey @Vulfox, thanks for taking the time to put together this PR.

Sorry for the long delay in responding, we've been very busy with other projects and haven't had time to review the enhancement contribution in a while. I'm hoping to make some time in the near-ish future to review all the enhancement PRs and put out a release for them. Thank you for your patience.

@ksandrmatveyev
Copy link

Hi,

Any updates on this?

@eikenb
Copy link
Contributor

eikenb commented Apr 3, 2021

Hey @ksandrmatveyev,

I'm so sorry that the delays keep coming, I feel like I've let the community down on many of these issues. Things are looking up though. We finally released the initial GA version of our other big project and I've got permission to switch back to working on this as soon as I finish up with a couple bugs that came up with that release.

So while it seems like I'm saying near the same thing again, this time I know I'll be back.

Please 👍 on the original post if you would, we use the reactions as a way of prioritizing.

Thanks.

@eikenb
Copy link
Contributor

eikenb commented Apr 27, 2021

This has been merged. Did it locally due to conflict issues and github didn't pick up on the fact that I merged it.

@eikenb eikenb closed this Apr 27, 2021
@Vulfox
Copy link
Contributor Author

Vulfox commented Apr 27, 2021

Thank you @eikenb !! I am a little sad it didn't make it to its birthday, but I am more glad it is merged!

@eikenb eikenb added this to the 0.26.0 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants