Issues 1456 1463, command quote bug #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out the bit that parses the command and add some tests for it. Includes a currently failing test `subshell-single-quoting` that triggered this.
|
Upstream PR to fix this is mattn/go-shellwords#49 |
Latest go-shellwords release has my fix for the shell quoting issue merged. Switching to it.
eikenb
force-pushed
the
issues-1456-1463-command-quote
branch
from
d6ce868 to
a245455
Compare
findkim
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that expose the problem and a go.mod replace directive to use a fixed fork of an upstream dependency where I've fixed the bug and submitted a PR but want to get it fixed for the release and the author probably won't get to it in time.
Edit: upstream merged my PR already and I changed this patch to use it instead of my fork
Fixes #1456
Fixes #1463