Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nomad Service Discovery Support #1565

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Add Nomad Service Discovery Support #1565

merged 4 commits into from
Apr 12, 2022

Conversation

schmichael
Copy link
Member

Adds 2 functions for retrieving services from Nomad:

  • nomadServices - retrieves all services from Nomad
  • nomadService - retrieves all registrations for a service

Tag filtering for nomadService is currently implemented in
consul-template as the Nomad API does not support it directly.

Tests use a Nomad binary on path and require Nomad 1.3.0-beta or a
binary built from the PR: hashicorp/nomad#12458

Tests also require Docker.

@schmichael schmichael requested a review from a team April 6, 2022 00:18
@eikenb eikenb added this to the v0.29.0 milestone Apr 6, 2022
@schmichael schmichael force-pushed the nomad-service-discovery branch 5 times, most recently from 0d62199 to bc0e9aa Compare April 11, 2022 22:21
@eikenb eikenb added enhancement hashicat-update-required Changes that need to be ported to hashicat nomad Related to ingetration in Nomad labels Apr 11, 2022
Adds 2 functions for retrieving services from Nomad:

- nomadServices - retrieves all services from Nomad
- nomadService - retrieves all registrations for a service

Tag filtering for `nomadService` is currently implemented in
consul-template as the Nomad API does not support it directly.

Tests use a Nomad binary on path and require Nomad 1.3.0-beta or a
binary built from the PR: hashicorp/nomad#12458

Tests also require Docker.
@schmichael schmichael force-pushed the nomad-service-discovery branch from 08818ce to ada73b6 Compare April 12, 2022 16:02
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Spent more time reviewing the integration points vs. the new functionality but saw no issue with either. Thanks!

And extra thanks for the mapstructure api test updates. ❤️

@eikenb eikenb merged commit 82ab0cf into master Apr 12, 2022
@eikenb eikenb deleted the nomad-service-discovery branch April 12, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hashicat-update-required Changes that need to be ported to hashicat nomad Related to ingetration in Nomad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants