Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template: allow nomad services to use byTag function. #1594

Merged
merged 1 commit into from
Jun 27, 2022
Merged

template: allow nomad services to use byTag function. #1594

merged 1 commit into from
Jun 27, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jun 27, 2022

@jrasell jrasell requested review from schmichael, shoenig and a team June 27, 2022 13:41
shoenig
shoenig approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eikenb
eikenb approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Though github's screwing up the spacing in the diff was a puzzler for a second.

@eikenb eikenb merged commit c588374 into main Jun 27, 2022
@eikenb eikenb deleted the f-nomad-gh-13459 branch June 27, 2022 19:16
@eikenb eikenb added this to the v0.30.0 milestone Jul 15, 2022
@eikenb eikenb modified the milestones: v0.30.0, v0.29.2 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikenb eikenb eikenb approved these changes

@shoenig shoenig shoenig approved these changes

@schmichael schmichael Awaiting requested review from schmichael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.29.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasell @shoenig @eikenb