Upgrade go modules to version which has CVE fixes #1615
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
Hey @noorul, thanks for the issue and PR! Dependabot is supposed to pick these things up... not sure why it missed this one. Thanks for reporting/fixing it. That failure is due to a changed error message in the latest consul release. If you wouldn't mind rebasing on HEAD and re-pushing this it should fix that and allow the CI testing to pass. |
noorul
force-pushed
the
noorul/fix-cves
branch
from
a4ab26c to
11ab87c
Compare
|
@eikenb rebased |
|
Thanks @noorul ! |
|
@eikenb Is CLA required for merge? |
I see why dependabot didn't pick it up... I haven't enabled dependabot in this repo yet. 🤦 |
|
@eikenb Can you enable dependabot? I will be happy to discard this patch as I need to do some paper work to sign CLA. |
|
I'll be happy to do that @noorul, I just like to use contributors submissions whenever possible. I'll work on getting dependabot enabled and making sure everything is up to date and happy. If you'd like to go that way please close this PR but leave the issue open. I should be able to mark it resolved in the Dependabot PR. Thanks! |
|
I have dependabot doing it's thing and am pretty sure I got this fixed with #1622. I'm still working on a few other dependabot updates but I'm going to go ahead and close this. Thanks again! |
|
@eikenb Great! Thank you! |
|
@eikenb Can we make a release? |
Fixes #1614