chore: refactor deprecated Vault calls #1768
Merged
+11
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,7 +138,7 @@ func (d *VaultReadQuery) Type() Type { | |||
| return TypeVault | |||
| } | |||
|
|
|||
| func (d *VaultReadQuery) readSecret(clients *ClientSet, opts *QueryOptions) (*api.Secret, error) { | |||
There was a problem hiding this comment.
good catch on opts not being used
roncodingenthusiast
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor for Vault related functionality in the
dependencypackage:NewLifetimeWatcher()instead ofNewWatcher()as it is deprecated (see API client reference here). For compatibility purposes,RenewBehaviouris the same as with the previous functionality.ReadRaw()instead ofRawRequest()as it is deprecated (see API client reference here).VaultReadQuerydependency, removeoptsfrom being passed further down to other functions as it is and won't be used. Query parameters (likeversion) for Vault read calls are stored in a separatequeryValuesfield. Other dependencies which implement the sameFetch()interface (likeFileQuery) won't pass it further either if the parameter is not needed.stopChan()function fromVaultPKIQuery.