Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add render event channel and refactor template run #988

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Add render event channel and refactor template run #988

merged 2 commits into from
Aug 9, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Aug 9, 2017

This PR does the following:

  • Refactors the Run command to pull the running of individual templates into
    their own method.
  • Adds a render event channel that is triggered when there is a new render event,
  • Fixes a bug in which the event was only added if the template was actually
    rendered versus dependencies changing.

@sethvargo for review

@sethvargo sethvargo merged commit 252f61d into master Aug 9, 2017
@sethvargo sethvargo deleted the b-render-events branch August 9, 2017 18:43
This was referenced Nov 2, 2018
Closed
Open
@sodabrew sodabrew mentioned this pull request Mar 5, 2019
Closed
@sodabrew sodabrew mentioned this pull request Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo sethvargo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadgar @sethvargo