Skip to content

Commit

Permalink
Cleanups, comments and a bit of logging
Browse files Browse the repository at this point in the history
Signed-off-by: Mark Anderson <[email protected]>
  • Loading branch information
markan committed Apr 13, 2022
1 parent 6e26ac8 commit 253c54e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions agent/connect/ca/provider_vault.go
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,9 @@ func (v *VaultProvider) unmountNamespaced(path string) error {
}

// namespace doesn't exist, try a different variant
// We match on the error string; this is more fragile in that it depends on vault behavior, but it preserves
// other errors. We could simply just retry on each error, which would be more robust but wouldn't necessarily
// return the most useful error message to the user.
if strings.Contains(err.Error(), "no handler for route") {
v.logger.Info(fmt.Sprintf("Attempted mount path %s for path %s, error %s", mountPath, path, err))
continue
Expand Down

0 comments on commit 253c54e

Please sign in to comment.