Skip to content

Commit

Permalink
Clean up dead code and comment
Browse files Browse the repository at this point in the history
  • Loading branch information
freddygv committed Nov 7, 2022
1 parent e43e898 commit 3d0b984
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions agent/xds/delta.go
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,6 @@ type xDSDeltaChild struct {
childrenNames map[string][]string
}

func (c *xDSDeltaChild) forceResubscribe(logger *hclog.Logger, parent string, child string) {

}

type xDSDeltaType struct {
generator *ResourceGenerator
stream ADSDeltaStream
Expand Down Expand Up @@ -730,7 +726,9 @@ func (t *xDSDeltaType) SendIfNew(
// we MUST send new data for all its children. Envoy will NOT re-subscribe to the child data upon
// receiving updates for the parent, so we need to handle this ourselves.
//
// Note that we do not check whether the deltaChild.childType is registered here, since we
// Note that we do not check whether the deltaChild.childType is registered here, since we send
// parent types before child types, meaning that it's expected on first send of a parent that
// there are no subscriptions for the child type.
if t.deltaChild != nil {
for name := range updates {
if children, ok := resourceMap.ChildIndex[t.typeURL][name]; ok {
Expand Down

0 comments on commit 3d0b984

Please sign in to comment.