address comments

hashicorp · Sep 6, 2023 · f00f303 · f00f303
1 parent e31cca3
commit f00f303
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/command/snapshot/save/snapshot_save.go b/command/snapshot/save/snapshot_save.go
@@ -83,7 +83,7 @@ func (c *cmd) Run(args []string) int {
 				c.UI.Error(fmt.Sprintf("Error fetching version of Consul agent Leader: %s", err))
 				return 1
 			}
-			version := ""
+			var version string
 			for _, server := range operatorHealthResponse.Servers {
 				if server.Leader {
 					version = server.Version

diff --git a/command/snapshot/save/snapshot_save_test.go b/command/snapshot/save/snapshot_save_test.go
@@ -105,9 +105,10 @@ func TestSnapshotSaveCommandWithAppendFileNameFlag(t *testing.T) {
 
 	datacenter := dc.(string)
 
-	operatorHealth, _ := client.Operator().AutopilotServerHealth(nil)
+	operatorHealth, error := client.Operator().AutopilotServerHealth(nil)
+	require.NoError(t, error)
 
-	version := ""
+	var version string
 	for _, server := range operatorHealth.Servers {
 		if server.Leader {
 			version = server.Version