pr feedback

Signed-off-by: FFMMM <[email protected]>
hashicorp · Dec 2, 2021 · f7081c1 · f7081c1
1 parent 468a401
commit f7081c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/agent/agent_endpoint.go b/agent/agent_endpoint.go
@@ -1520,6 +1520,7 @@ func (s *HTTPHandlers) AgentConnectCALeafCert(resp http.ResponseWriter, req *htt
 	args.MaxQueryTime = qOpts.MaxQueryTime
 	args.Token = qOpts.Token
 
+	// TODO(ffmmmm): maybe set MustRevalidate in ConnectCALeafRequest (as part of CacheInfo())
 	// We don't want non-blocking queries to return expired leaf certs
 	// or leaf certs not valid under the current CA. So always revalidate
 	// the leaf cert on non-blocking queries (ie when MinQueryIndex == 0)

diff --git a/agent/agent_endpoint_test.go b/agent/agent_endpoint_test.go
@@ -5837,16 +5837,14 @@ func TestAgentConnectCALeafCert_good(t *testing.T) {
 
 		// Test caching for the leaf cert
 		{
-			
-			for fetched := 0; fetched < 4; fetches++ {
+
+			for fetched := 0; fetched < 4; fetched++ {
 
 				// Fetch it again
 				resp := httptest.NewRecorder()
 				obj2, err := a.srv.AgentConnectCALeafCert(resp, req)
 				require.NoError(err)
 				require.Equal(obj, obj2)
-
-				fetched++
 			}
 		}
 	})