Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup config_entry CanRead/CanWrite code to give detailed error messages #12241

Closed
markan opened this issue Feb 1, 2022 · 0 comments
Closed

Cleanup config_entry CanRead/CanWrite code to give detailed error messages #12241

markan opened this issue Feb 1, 2022 · 0 comments
Labels
theme/acls ACL and token generation theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization

Comments

@markan
Copy link
Contributor

markan commented Feb 1, 2022

Currently the config_entry.go subsystem delegates authorization decisions via the ConfigEntry interface CanRead and CanWrite code. Unfortunately this returns a true/false value and loses the details of the source.

This is not helpful, especially since it the config subsystem can be more complex to understand, since it covers so many domains.

We should refactor CanRead/CanWrite to return a structured error message (PermissionDenied or the like) with more details about the reason for denial.
@markan markan added theme/acls ACL and token generation theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization labels Feb 1, 2022
@markan markan mentioned this issue Mar 1, 2022
Merged
@markan markan mentioned this issue Mar 11, 2022
Merged
markan added a commit that referenced this issue Mar 11, 2022
@markan
Refactor config checks oss (#12550)
676ea58 
Currently the config_entry.go subsystem delegates authorization decisions via the ConfigEntry interface CanRead and CanWrite code. Unfortunately this returns a true/false value and loses the details of the source.

This is not helpful, especially since it the config subsystem can be more complex to understand, since it covers so many domains.

This refactors CanRead/CanWrite to return a structured error message (PermissionDenied or the like) with more details about the reason for denial.

Part of #12241

Signed-off-by: Mark Anderson <[email protected]>
@markan markan closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/acls ACL and token generation theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markan