[1.11.x] Add support for Envoy 1.20.2 #12433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/envoy/xds
eculver
changed the title
eculver
changed the title
|
Tracking envoyproxy/envoy#20098 for this version issue Looks like it was ACK'ed, but unsure if we want to wait for versions to be fixed or just push ahead with -dev |
kisunji
approved these changes
Feb 24, 2022
eculver
added
the
pr/no-changelog
|
FYI - I'm applying the |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/596009. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our Envoy integration test matrix to include 1.20.2. The only notable change that was needed was to match against the Envoy version string which is:
Note the
-devsuffix.This little version issue causes all the tests that use the
assert_envoy_versionhelper to fail. To work around it, I just temporarily re-write theENVOY_VERSIONvariable to include the suffix.All other integration tests passed.
FUN FACT: The latest releases for Envoy 1.19 and 1.18 also have this
-devsuffix that we'll need to deal with as well.