docs: all enterprise locality labels now optional #14679
Conversation
jkirschner-hashicorp
added
the
type/docs
jkirschner-hashicorp
force-pushed
the
docs/improve-ent-dns-flexibility-oss
branch
2 times, most recently
from
ff9a3c0 to
e234987
Compare
jkirschner-hashicorp
force-pushed
the
docs/improve-ent-dns-flexibility-oss
branch
2 times, most recently
from
1429019 to
b24b802
Compare
jkirschner-hashicorp
force-pushed
the
docs/improve-ent-dns-flexibility-oss
branch
from
b24b802 to
90aab0b
Compare
jkirschner-hashicorp
requested review from
trujillo-adam
and removed request for
boruszak
|
@trujillo-adam : tagging you, since you were involved in the recent review of this section: #14389 This PR is a change of the existing section to account for new functionality targeting release in 1.14. |
| ```text | ||
| [<tag>.]<service>.service[.<namespace>.ns][.<partition>.ap][.<datacenter>.dc]<domain> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
| Use the [prepared query lookup format](#prepared-query-lookups) for `.query` lookups. | |
Correct?
There was a problem hiding this comment.
I like the suggestion. It's best to redirect people to where they need to go.
Unfortunately, my understanding is that prepared queries don't support enterprise locality labels at all. And if that's true, maybe that's what needs to be stated explicitly.
There was a problem hiding this comment.
I'll avoid making this change in this PR.
I'll make it in a follow-up PR because it requires some updates to the prepared query docs as well, and I don't want to delay the merging of the enterprise code PR for that follow-up PR.
|
@trujillo-adam : I believe I've addressed your feedback. Ready for re-review! |
jkirschner-hashicorp
deleted the
docs/improve-ent-dns-flexibility-oss
branch
Documenting capabilities introduced by a Consul Enterprise PR (3072).
Preview: https://consul-cuhodfsls-hashicorp.vercel.app/docs/discovery/dns#service-lookups-for-consul-enterprise