docs: re-organize service and node lookups for Consul Enterprise #14389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-yu
added
type/docs-cherrypick
pr/no-changelog
github-actions
bot
added
the
type/docs
Co-authored-by: trujillo-adam <[email protected]>
trujillo-adam
approved these changes
Aug 29, 2022
jkirschner-hashicorp
requested changes
Aug 30, 2022
There was a problem hiding this comment.
@david-yu : thanks for taking this on! I made some suggestions that:
- Make defaults explicit
- Break out virtual IP lookups from other service lookups
Co-authored-by: Jared Kirschner <[email protected]>
Co-authored-by: Jared Kirschner <[email protected]>
jkirschner-hashicorp
requested changes
Aug 30, 2022
There was a problem hiding this comment.
@david-yu : small follow up after looking at the Vercel preview
Co-authored-by: Jared Kirschner <[email protected]>
Co-authored-by: Jared Kirschner <[email protected]>
jkirschner-hashicorp
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor enterprise node and service lookups into their respective sections, as opposed to having enterprise lookups in its own section.
Testing & Reproduction steps
Links
Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.
Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.
PR Checklist