Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate child process reaping #1988

Closed
slackpad opened this issue Apr 26, 2016 · 3 comments
Closed

Deprecate child process reaping #1988

slackpad opened this issue Apr 26, 2016 · 3 comments
Labels
type/enhancement Proposed improvement or new feature
Milestone

Comments

@slackpad
Copy link
Contributor

Now that we've got an official Consul image that does child process reaping via dumb-init, we should remove the child process reaping features baked into Consul itself. These work properly, but they have complex interactions with Consul's other uses of child processes, so they present a maintenance headache going forward.

@slackpad slackpad added type/enhancement Proposed improvement or new feature easy labels Apr 26, 2016
@jippi
Copy link
Contributor

jippi commented Apr 27, 2016

👎 people still may opt out of that option and roll their own image, where the reaping would be beneficial

@slackpad
Copy link
Contributor Author

Hi @jippi it's definitely true that not everybody will want to use the official image, but it's pretty simple to configure something outside of Consul to do the reaping in your own container, so we will document that. The reap lock is just plain ugly and it's super easy to forget to do it in the code and introduce subtle errors, so that doesn't seem worth the liability. Adding reaping inside the container was basically just a matter of including dumb-init and adding a single line to the entrypoint, which is a lot cleaner.

@jippi
Copy link
Contributor

jippi commented Apr 27, 2016

@slackpad alright, kill it with fire then :)

slackpad added a commit that referenced this issue Oct 7, 2016
Remove the child process reaper (resolve #1988)
@slackpad slackpad added this to the 0.7.1 milestone Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants