You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we've got an official Consul image that does child process reaping via dumb-init, we should remove the child process reaping features baked into Consul itself. These work properly, but they have complex interactions with Consul's other uses of child processes, so they present a maintenance headache going forward.
The text was updated successfully, but these errors were encountered:
Hi @jippi it's definitely true that not everybody will want to use the official image, but it's pretty simple to configure something outside of Consul to do the reaping in your own container, so we will document that. The reap lock is just plain ugly and it's super easy to forget to do it in the code and introduce subtle errors, so that doesn't seem worth the liability. Adding reaping inside the container was basically just a matter of including dumb-init and adding a single line to the entrypoint, which is a lot cleaner.
Now that we've got an official Consul image that does child process reaping via dumb-init, we should remove the child process reaping features baked into Consul itself. These work properly, but they have complex interactions with Consul's other uses of child processes, so they present a maintenance headache going forward.
The text was updated successfully, but these errors were encountered: