Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set success_before_passing and failures_before_critical via agent endpoint #7764

Closed
onimsha opened this issue May 4, 2020 · 0 comments · Fixed by #7949
Closed
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature

Comments

@onimsha
Copy link

onimsha commented May 4, 2020

Please search the existing issues for relevant feature requests, and use the reaction feature (https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to add upvotes to pre-existing requests.

Feature Description

Consul Agent Endpoint /v1/check/register and /v1/service/register should accept success_before_passing and failures_before_critical in the payload. Right now (consul 1.7.2) it returns HTTP 400 and does not recognise these fields.

Use Case(s)

With system that relies on the agent endpoint to register services & checks on startup and doesn't want to use a configuration file on the agent side, this feature is really a big help.

For example our system is using a discovery process, when the application is doing some preparation, gather host's information before sending the request to consul agent for service registration.

@jsosulska jsosulska added theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature labels May 4, 2020
shoenig added a commit that referenced this issue May 22, 2020
…ical in API

Fixes #7764

Until now these two fields could only be set through on-disk agent configuration.
This change adds the fields to the agent API struct definition so that they can
be set using the agent HTTP API.
hanshasselberg pushed a commit that referenced this issue Jun 29, 2020
…ical in API (#7949)

Fixes #7764

Until now these two fields could only be set through on-disk agent configuration.
This change adds the fields to the agent API struct definition so that they can
be set using the agent HTTP API.
hashicorp-ci pushed a commit that referenced this issue Jun 29, 2020
…ical in API (#7949)

Fixes #7764

Until now these two fields could only be set through on-disk agent configuration.
This change adds the fields to the agent API struct definition so that they can
be set using the agent HTTP API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants