connect: Remove support for Envoy 1.16 #11354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/envoy/xds
rboyer
reviewed
Oct 27, 2021
agent/xds/server.go
Outdated
|
|
||
| return err | ||
| } | ||
|
|
||
| const ( | ||
| stateInit int = iota |
There was a problem hiding this comment.
I think these can be deleted too. I forked them for delta.
rboyer
approved these changes
Oct 27, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/487837. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar for what we did with Envoy 1.19/1.15 in #11115 and #11118 respectively, this stacks on top of #11277 to remove support for Envoy 1.16.5. The stacking helps keep these changes isolated and easier to review while also allowing me to merge them in close succession.
As for the actual removal of 1.16.5, this is a relatively significant change since, for versions of Envoy 1.17+, xDS v2 is officially deprecated. This means we no longer need the v2 <-> v3 conversion code so it has been removed.
Question to reviewers: is there any reason why we need v2 code? @rboyer and I landed on no but it would be good to get more eyes on it.
TODO: