Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Filter global intentions list by selected partition #11475

Merged
merged 4 commits into from
Nov 9, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/packages/consul-ui/app/adapters/intention.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { get } from '@ember/object';
// Listing of intentions still requires the `ns` query string parameter which
// will give us all the intentions that have the `ns` as either the SourceNS or
// the DestinationNS.
// We currently list intentions by the * wildcard namespace for back compat reasons
// TODO: Change the above so that we only list intentions with
// Source/Destination in the currently selected nspace

// TODO: Investigate the above to see if we should only list intentions with
// Source/Destination in the currently selected nspace or leave as is.
export default class IntentionAdapter extends Adapter {
requestForQuery(request, { dc, ns, partition, filter, index, uri }) {
return request`
Expand All @@ -21,7 +21,7 @@ export default class IntentionAdapter extends Adapter {
}

${{
partition: '*',
partition,
ns: '*',
index,
filter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module('Integration | Adapter | intention', function(hooks) {
filter: '*',
index: 1,
ns: '*',
partition: '*',
partition: 'partition-1',
},
{
filter: '*',
Expand Down