Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Support vault namespaces in connect CA into release/1.12.x #12948

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #12904 to be assessed for backporting due to the inclusion of the label backport/1.12.

The below text is copied from the body of the original PR.


Follow on to some missed items from #12655

Description

From an internal ticket "Support standard "Vault namespace in the
path" semantics for Connect Vault CA Provider"

Vault allows the namespace to be specified as a prefix in the path of
a PKI definition, but our usage of the Vault API includes calls that
don't support a namespaced key. In particular the sys.* family of
calls simply appends the key, instead of prefixing the namespace in
front of the path.

Unfortunately it is difficult to reliably parse a path with a
namespace; only vault knows what namespaces are present, and the '/'
separator can be inside a key name, as well as separating path
elements. This is in use in the wild; for example
'dc1/intermediate-key' is a relatively common naming schema.

Instead we add two new fields: RootPKINamespace and
IntermediatePKINamespace, which are the absolute namespace paths
'prefixed' in front of the respective PKI Paths.

Testing & Reproduction steps

[ ] manual testing

Links

Asana task

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern
  • checklist folder consulted

Signed-off-by: Mark Anderson [email protected]

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner May 5, 2022 16:23
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ma/vault-namespace-intermediate-provider-v2/intensely-rational-seasnail branch from 21e4a63 to e75e7e6 Compare May 5, 2022 16:23
@github-actions github-actions bot added theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/docs Documentation needs to be created/updated/clarified labels May 5, 2022
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@markan markan added the pr/no-changelog PR does not need a corresponding .changelog entry label May 5, 2022
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions - otherwise LGTM!

website/content/docs/connect/ca/vault.mdx Outdated Show resolved Hide resolved
website/content/docs/connect/ca/vault.mdx Outdated Show resolved Hide resolved
@markan markan merged commit a0b027d into release/1.12.x Jun 1, 2022
@markan markan deleted the backport/ma/vault-namespace-intermediate-provider-v2/intensely-rational-seasnail branch June 1, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants