-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Consul API Gateway scaling config #13333
Conversation
…ces and deployment.minInstances
a68b85c
to
3afe19c
Compare
3afe19c
to
f2f011c
Compare
website/content/docs/api-gateway/consul-api-gateway-install.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor suggestions to phrasing to improve clarity. Per my comment, please feel free to reach out if you need additional assistance with the phrasing.
Otherwise, LGTM! Thanks!
website/content/docs/api-gateway/consul-api-gateway-install.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/api-gateway/consul-api-gateway-install.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
@@ -168,6 +168,9 @@ The following table describes the allowed parameters for the `spec` array: | |||
| `consul.ports.http` | Specifies the port for Consul's HTTP server. | Integer | `8500` | | |||
| `consul.scheme` | Specifies the scheme to use for connecting to Consul. The supported values are `"http"` and `"https"`. | String | `"http"` | | |||
| `copyAnnotations.service` | List of annotations to copy to the gateway service. | Array | `["external-dns.alpha.kubernetes.io/hostname"]` | | |||
| `deployment.defaultInstances` | Specifies the number of instances to deploy by default for each gateway. | Integer | 1 | | |||
| `deployment.maxInstances` | Specifies the maximum allowed number of instances per gateway. | Integer | 8 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that 8
is the absolute max for this value?
Going to go ahead and merge since the base has changed from |
Description
Add docs for GatewayClasConfig
defaultInstances
,maxInstances
andminInstances
fields, and instructions for manually scaling the number of replicas for a Gateway Deployment.This should not be published until after the next release of Consul API Gateway.
Testing & Reproduction steps
apiGateway.image
config inlocal/consul/config.yaml
to use a Docker image built from themain
branch of http://github.com/hashicorp/consul-api-gateway/deployment.defaultInstances
,deployment.maxInstances
anddeployment.minInstances
manually in a GatewayClassConfig after removing themanagedGatewayClass
config fromlocal/consul/config.yaml
in a fresh deployment, then creating a Gateway (Deployment replicas should initially reflectdeployment.defaultInstances
) and attempting to scale the Deployment outside of the set bounds.Links
PR Checklist
updated test coverage