Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Consul API Gateway scaling config #13333

Merged
merged 8 commits into from
Jun 13, 2022

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Jun 1, 2022

Description

Add docs for GatewayClasConfig defaultInstances, maxInstances and minInstances fields, and instructions for manually scaling the number of replicas for a Gateway Deployment.

This should not be published until after the next release of Consul API Gateway.

Testing & Reproduction steps

  • Follow the Learn guide to deploy Consul API Gateway, modifying the apiGateway.image config in local/consul/config.yaml to use a Docker image built from the main branch of http://github.com/hashicorp/consul-api-gateway/
  • Scale the Gateway Deployment following the documented steps.
  • [Not tested yet] Specify deployment.defaultInstances, deployment.maxInstances and deployment.minInstances manually in a GatewayClassConfig after removing the managedGatewayClass config from local/consul/config.yaml in a fresh deployment, then creating a Gateway (Deployment replicas should initially reflect deployment.defaultInstances) and attempting to scale the Deployment outside of the set bounds.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern
  • checklist folder consulted

@mikemorris mikemorris requested a review from a team June 1, 2022 18:51
@mikemorris mikemorris requested a review from a team as a code owner June 1, 2022 18:51
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 1, 2022
@mikemorris mikemorris added pr/no-changelog PR does not need a corresponding .changelog entry pr/do-not-merge PR cannot be merged in its current form. labels Jun 1, 2022
@mikemorris mikemorris force-pushed the docs/capig-instances-config branch from a68b85c to 3afe19c Compare June 1, 2022 19:01
@nathancoleman nathancoleman changed the base branch from main to docs/capigw-0.3 June 7, 2022 19:44
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor suggestions to phrasing to improve clarity. Per my comment, please feel free to reach out if you need additional assistance with the phrasing.

Otherwise, LGTM! Thanks!

@@ -168,6 +168,9 @@ The following table describes the allowed parameters for the `spec` array:
| `consul.ports.http` | Specifies the port for Consul's HTTP server. | Integer | `8500` |
| `consul.scheme` | Specifies the scheme to use for connecting to Consul. The supported values are `"http"` and `"https"`. | String | `"http"` |
| `copyAnnotations.service` | List of annotations to copy to the gateway service. | Array | `["external-dns.alpha.kubernetes.io/hostname"]` |
| `deployment.defaultInstances` | Specifies the number of instances to deploy by default for each gateway. | Integer | 1 |
| `deployment.maxInstances` | Specifies the maximum allowed number of instances per gateway. | Integer | 8 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that 8 is the absolute max for this value?

@nathancoleman
Copy link
Member

Going to go ahead and merge since the base has changed from main to our docs branch for 0.3.0. Other members of the team can base their docs changes for this 0.3.0 release off the branch as well.

@nathancoleman nathancoleman merged commit ce3d492 into docs/capigw-0.3 Jun 13, 2022
@nathancoleman nathancoleman deleted the docs/capig-instances-config branch June 13, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants