Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10] docs: Correct Envoy support matrix #14334

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Aug 24, 2022

Description

Long ago, when I was first learning how our Envoy support matrix worked, I inadvertently backported support for Envoy 1.20 to Consul 1.10: #12434. Since this patch was related to a CVE, my guess is that we wanted to be able to give users an upgrade path to a patched Envoy. However, for Consul 1.10, they could do this with Envoy 1.18.6 as opposed to adding support for Envoy 1.20. Alas, this is the history and I cannot go back and change it.

With that said, we don't want to confuse users about our Envoy support matrix, so this resets our docs for 1.10 to what the expected support should be for Consul 1.10. These values are what should also be documented in the Consul 1.12 and 1.11 docs. There will be accompanying PRs for Consul 1.12 and 1.11 linked below.

In the end, all the docs linked below should have consistent Envoy versions for each release series.

Links

@eculver eculver added the pr/no-changelog PR does not need a corresponding .changelog entry label Aug 24, 2022
@eculver eculver requested a review from david-yu August 24, 2022 20:19
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Aug 24, 2022
@eculver eculver changed the title docs: Correct Envoy support matrix [1.10] docs: Correct Envoy support matrix Aug 24, 2022
@eculver
Copy link
Contributor Author

eculver commented Aug 24, 2022

Ignore the integration test failures. It is a known issue for them to fail since they are testing against nomad@main which now depends on Go 1.19.

@eculver eculver merged commit 0d4f712 into release/1.10.x Aug 24, 2022
@eculver eculver deleted the eculver/1.10/envoy-docs branch August 24, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants