Add SpiffeID for Consul server agents #14485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
theme/connect
By adding a SpiffeID for server agents, servers can now request a leaf certificate from the Connect CA. This new Spiffe ID has a key property: servers are identified by their datacenter name and trust domain. All servers that share these attributes will share a ServerURI. The aim is to use these certificates to verify the server name of ANY server in a Consul datacenter.
freddygv
force-pushed
the
NET-818-add-an-internally-managed-server-certificate-for-consul-servers
branch
from
99dbd14 to
f95a6d2
Compare
freddygv
added
the
pr/no-changelog
freddygv
requested review from
a team and
dhiaayachi
and removed request for
a team
erichaberkorn
approved these changes
Sep 6, 2022
Co-authored-by: Eric Haberkorn <[email protected]>
DanStough
reviewed
Sep 6, 2022
Comment on lines
+227
to
+230
| // ServerURI is the URI value of a cert issued for a server agent. | ||
| // The same URI is shared by all servers in a Consul datacenter. | ||
| ServerURI string `json:",omitempty"` | ||
|
|
There was a problem hiding this comment.
Just curious why IssuedCert isn't exported from the API package? Looks like it's returned from at least one endpoint /v1/agent/connect/ca/leaf/test?token=<token>.
There was a problem hiding this comment.
@DanStough It is in the api package, but for some reason it has a different name there. I assume it was for clarity? 9638466
Cert type:
Line 108 in 8c46e48
Endpoint client:
Line 1112 in 8c46e48
We don't need to expose ServerURI via that type because users can't request leaf certs for Consul servers.
freddygv
deleted the
NET-818-add-an-internally-managed-server-certificate-for-consul-servers
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By adding a SpiffeID for server agents, servers can now request a leaf
certificate from the Connect CA.
This new Spiffe ID has a key property: servers are identified by their
datacenter name and trust domain. All servers that share these
attributes will share a ServerURI.
The aim is to use these certificates to verify the server name of ANY
server in a Consul datacenter.
Testing & Reproduction steps
Links
https://go.hashi.co/csl-204-server-cert
PR Checklist