Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update /v1/agent/self #14987

Closed
wants to merge 2 commits into from
Closed

Conversation

nvanthao
Copy link
Contributor

Description

/v1/agent/self endpoint returns the configuration and member information of the local agent. This endpoint, however, does not reflect the runtime configurations after Consul reloads

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@nvanthao nvanthao requested a review from a team as a code owner October 14, 2022 01:23
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 14, 2022
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a little clarification

website/content/api-docs/agent/index.mdx Outdated Show resolved Hide resolved
@jkirschner-hashicorp
Copy link
Contributor

Thank you for updating the docs to more fully describe current behavior!

Given reloading might be used more often going forward (e.g., auto-reload), I recommend we create a separate Github issue to track making this API endpoint return the current config, not just the config on startup.

@jkirschner-hashicorp jkirschner-hashicorp added type/docs-cherrypick pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test labels Oct 14, 2022
@nvanthao
Copy link
Contributor Author

Hi Jared,

I have created an internal bug report with reference number 1203169189302122 prior to this doc PR. Please let me know if a Github Issue is still required.

Cheers,

@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Dec 18, 2022
@nvanthao
Copy link
Contributor Author

closing due to the bug is fixed with #18681

@nvanthao nvanthao closed this Sep 14, 2023
@nvanthao nvanthao deleted the gerard/api-docs branch September 14, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants