Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Docs: change connect to SM for mTLS page into release/1.12.x #16135

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16082 to be assessed for backporting due to the inclusion of the label backport/1.12.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: unable to process merge commit: "a06e68b8c688095e5d6ade5dd8f2607a08d82729", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

Describe why you're making this change, in plain English.

Testing & Reproduction steps

  • In the case of bugs, describe how to replicate
  • If any manual tests were done, document the steps and the conditions to replicate
  • Call out any important/ relevant unit tests, e2e tests or integration tests you have added or are adding

Links

Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.

Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/nrichu-hcp-doc-patch/amazingly-relieved-sculpin branch from 7ce7f67 to a21a241 Compare February 2, 2023 14:41
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/nrichu-hcp-doc-patch/amazingly-relieved-sculpin branch from 2fbd738 to 4625c7b Compare February 2, 2023 14:41
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Feb 2, 2023
@nrichu-hcp nrichu-hcp marked this pull request as ready for review February 2, 2023 18:58
@nrichu-hcp nrichu-hcp requested a review from a team as a code owner February 2, 2023 18:58
@nrichu-hcp nrichu-hcp merged commit 4911b8e into release/1.12.x Feb 2, 2023
@nrichu-hcp nrichu-hcp deleted the backport/docs/nrichu-hcp-doc-patch/amazingly-relieved-sculpin branch February 2, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants