-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual backport of #16291 #16410
Merged
Merged
Manual backport of #16291 #16410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
Documentation needs to be created/updated/clarified
label
Feb 23, 2023
nathancoleman
commented
Feb 23, 2023
nathancoleman
added
the
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
label
Feb 23, 2023
* initial commit * initial commit * Overview updates * Overview page improvements * More Overview improvements * improvements * Small fixes/updates * Updates * Overview updates * Nav data * More nav updates * Fix * updates * Updates + tip test * Directory test * refining * Create restructure w/ k8s * Single usage page * Technical Specification * k8s pages * typo * L7 traffic management * Manage connections * k8s page fix * Create page tab corrections * link to k8s * intentions * corrections * Add-on intention descriptions * adjustments * Missing </CodeTabs> * Diagram improvements * Final diagram update * Apply suggestions from code review Co-authored-by: trujillo-adam <[email protected]> Co-authored-by: Tu Nguyen <[email protected]> Co-authored-by: David Yu <[email protected]> * diagram name fix * Fixes * Updates to index.mdx * Tech specs page corrections * Tech specs page rename * update link to tech specs * K8s - new pages + tech specs * k8s - manage peering connections * k8s L7 traffic management * Separated establish connection pages * Directory fixes * Usage clean up * k8s docs edits * Updated nav data * CodeBlock Component fix * filename * CodeBlockConfig removal * Redirects * Update k8s filenames * Reshuffle k8s tech specs for clarity, fmt yaml files * Update general cluster peering docs, reorder CLI > API > UI, cross link to kubernetes * Fix config rendering in k8s usage docs, cross link to general usage from k8s docs * fix legacy link * update k8s docs * fix nested list rendering * redirect fix * page error --------- Co-authored-by: trujillo-adam <[email protected]> Co-authored-by: Tu Nguyen <[email protected]> Co-authored-by: David Yu <[email protected]> Co-authored-by: Tu Nguyen <[email protected]>
nathancoleman
force-pushed
the
fix-vercel-failure
branch
from
February 23, 2023 21:48
beaa1d0
to
9e35033
Compare
nathancoleman
requested review from
sarahethompson and
claire-labry
and removed request for
a team
February 23, 2023 21:48
nathancoleman
changed the title
Add cluster peering configuration page to nav
Manual backport of #16291
Feb 23, 2023
nathancoleman
removed
the
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
label
Feb 23, 2023
boruszak
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for you help with this issue, Nathan!
Approving to allow the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an error causing Vercel to fail on
release/1.15.x
branches.The error was introduced when the backport of #16291, #16398, failed to remove a file that was removed in the initial PR.
Testing & Reproduction steps
Links
Example Vercel failure
PR Checklist