Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Update docs into release/1.16.x #17899

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17476 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@trujillo-adam
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "a6520c4656c1f47b63dff542e90db4df181275c5", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

Documentation had different/missing protocol field for each of the three examples


Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 27, 2023
@trujillo-adam trujillo-adam marked this pull request as ready for review July 10, 2023 21:37
@trujillo-adam trujillo-adam requested a review from a team as a code owner July 10, 2023 21:37
@trujillo-adam trujillo-adam merged commit efb87e4 into release/1.16.x Jul 10, 2023
@trujillo-adam trujillo-adam deleted the backport/patch-2/similarly-quality-mite branch July 10, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants