command: escape the script string provided to lock #1845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits deals with executions of the lock command that look like this: $ consul lock / mkdir "a b" c Before this commit, three directories would be created: a, b and c. With this commit, only two will be created: "a b" and c; which is what the user expects. I've added a specific test for it and I've also modified the rest of the tests to simulate better what's actually being passed to the CLI. Fixes hashicorp#1621 Signed-off-by: Miquel Sabaté Solà <[email protected]>
|
Hey @mssola, sorry for the delay here! I think this could also be avoided by simply enclosing the command to execute in quotes, like: By automatically inserting double-quotes I think we are opening up the possibility for further unexpected behavior in cases where there may also be double-quotes in the command. Does that make sense? |
|
Yeah. Thanks for the clarification. Closing this PR, and I guess that you'll do the same in the referenced issue 😉 |
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits deals with executions of the lock command that look like this:
Before this commit, three directories would be created: a, b and c. With this
commit, only two will be created: "a b" and c; which is what the user expects.
I've added a specific test for it and I've also modified the rest of the tests
to simulate better what's actually being passed to the CLI.
Fixes #1621
Signed-off-by: Miquel Sabaté Solà [email protected]