Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of feat: Change global-read-only policy to non editable into release/1.16.x #18749

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18602 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@valeriia-ruban
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Update global-read-only to non editable
image
image

Testing & Reproduction steps

  1. set up CONSUL_ACLS_ENABLE to 1 in session storage
  2. set CONSUL_POLICY_COUNT = 10
  3. go to Policies
  4. log in with any securId
  5. check list of items to see global-read-only policy
  6. go to the policy details and check that form is non-editable

Links

JIRA
Figma

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/feature/make-global-read-only-policy-non-editable/yearly-actual-cattle branch from 950ebd0 to d6f9465 Compare September 11, 2023 20:27
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/feature/make-global-read-only-policy-non-editable/yearly-actual-cattle branch 2 times, most recently from cf3d28e to d6f9465 Compare September 11, 2023 20:27
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/ui Anything related to the UI label Sep 11, 2023
@vercel vercel bot temporarily deployed to Preview – consul September 11, 2023 20:32 Inactive
@valeriia-ruban valeriia-ruban marked this pull request as ready for review September 11, 2023 21:01
@valeriia-ruban valeriia-ruban added the pr/no-changelog PR does not need a corresponding .changelog entry label Sep 11, 2023
@valeriia-ruban valeriia-ruban merged commit dfc3e2e into release/1.16.x Sep 11, 2023
@valeriia-ruban valeriia-ruban deleted the backport/ui/feature/make-global-read-only-policy-non-editable/yearly-actual-cattle branch September 11, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants