Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parallel flag #19057

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Remove parallel flag #19057

merged 1 commit into from
Oct 4, 2023

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 4, 2023 •
edited
Loading

Description

The -p and -test.parallel flag both default to GOMAXPROCS (which defaults to number of CPU cores), so we have no reason to explicitly set the test parallelism.

        -p n
                the number of programs, such as build commands or
                test binaries, that can be run in parallel.
                The default is GOMAXPROCS, normally the number of CPUs available.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
consul ⬜️ Ignored (Inspect) Oct 4, 2023 2:12pm
consul-ui-staging ⬜️ Ignored (Inspect) Oct 4, 2023 2:12pm

@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Oct 4, 2023
@kisunji kisunji requested a review from huikang October 4, 2023 14:14
@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 4, 2023
@kisunji kisunji enabled auto-merge (squash) October 4, 2023 14:51
nfi-hashicorp
nfi-hashicorp approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@nfi-hashicorp nfi-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM provided it works fine ;)

@kisunji kisunji merged commit 1a9666c into main Oct 4, 2023
@kisunji kisunji deleted the kisunji/compat-test branch October 4, 2023 15:47
ishustava added a commit that referenced this pull request Oct 4, 2023
@ishustava
Revert "Remove parallel flag (#19057)"
1836c52 
This reverts commit 1a9666c.
ishustava added a commit that referenced this pull request Oct 4, 2023
@ishustava
Revert "Remove parallel flag (#19057)"
09febfd 
This reverts commit 1a9666c.
jmurret pushed a commit that referenced this pull request Oct 5, 2023
@jmurret
Remove parallel flag (#19057)
cd1421d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfi-hashicorp nfi-hashicorp nfi-hashicorp approved these changes

@huikang huikang Awaiting requested review from huikang

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kisunji @nfi-hashicorp