Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old build tags #19128

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove old build tags #19128

merged 1 commit into from
Oct 10, 2023

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 10, 2023

Description

I've noticed these tags get copy-pasted in new files and thought it would be best to clean them up.
This style of build tags has not been used since go1.18 and since our latest supported version is on Consul 1.20 it's safe to remove them moving forwards.

@kisunji kisunji requested a review from a team as a code owner October 10, 2023 14:19
@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 10, 2023
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/acls ACL and token generation theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication theme/telemetry Anything related to telemetry or observability theme/envoy/xds Related to Envoy support theme/certificates Related to creating, distributing, and rotating certificates in Consul labels Oct 10, 2023
@kisunji kisunji enabled auto-merge (squash) October 10, 2023 14:40
@kisunji kisunji merged commit 92ce814 into main Oct 10, 2023
@kisunji kisunji deleted the kisunji/remove-build-tags branch October 10, 2023 14:58
jmurret pushed a commit that referenced this pull request Oct 12, 2023
@jmurret
Remove old build tags (#19128)
b399a18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncodingenthusiast roncodingenthusiast roncodingenthusiast approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/acls ACL and token generation theme/api Relating to the HTTP API interface theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/envoy/xds Related to Envoy support theme/telemetry Anything related to telemetry or observability theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kisunji @roncodingenthusiast