Backport of Vault CA bugfixes into release/1.15.x #19307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2023 14:40
hc-github-team-consul-core
force-pushed
the
backport/kisunji/vault-ca-fixes/awfully-smooth-katydid
branch
from
a78f05b to
cbcd39f
Compare
hc-github-team-consul-core
force-pushed
the
backport/kisunji/vault-ca-fixes/awfully-smooth-katydid
branch
2 times, most recently
from
75f76ef to
cbcd39f
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 20, 2023
github-actions
bot
added
the
theme/connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19285 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@kisunji
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Fixing edge case bugs uncovered by #19051
Testing & Reproduction steps
Added tests for goroutine leak detection.
The retry functionality is a revert of #16143 and was tested manually.
Overview of commits