Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of added redirect for conf entries 1.8.x into release/1.12.x #19461

Closed
wants to merge 2 commits into from
Closed

Backport of added redirect for conf entries 1.8.x into release/1.12.x #19461

wants to merge 2 commits into from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19460 to be assessed for backporting due to the inclusion of the label backport/1.12.

The below text is copied from the body of the original PR.

Description

Prior to v1.9.x, configuration entries appeared int he /agent dir instead the /connect dir. This PR redirects people who view a conf entry in the current /connect folder and switch to docs v1.8.x so that they land on the conf entry in the /agent folder. Fixes per this Slack thread.

PR Checklist

  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/add-redirects-1.8-conf-entries/factually-relieved-flounder branch from 555cd5b to 9805034 Compare November 1, 2023 17:41
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/add-redirects-1.8-conf-entries/factually-relieved-flounder branch from 73c353b to ce7c510 Compare November 1, 2023 17:41
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Nov 1, 2023
@hc-github-team-consul-core
Copy link
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul November 1, 2023 17:46 Inactive
auto-merge was automatically disabled November 1, 2023 18:04

Pull request was closed

@trujillo-adam trujillo-adam reopened this Nov 1, 2023
@trujillo-adam trujillo-adam enabled auto-merge (squash) November 1, 2023 18:04
@trujillo-adam trujillo-adam removed the type/docs Documentation needs to be created/updated/clarified label Nov 1, 2023
auto-merge was automatically disabled November 1, 2023 18:34

Pull request was closed

@trujillo-adam trujillo-adam reopened this Nov 1, 2023
@trujillo-adam trujillo-adam reopened this Nov 1, 2023
@im2nguyen im2nguyen closed this Nov 1, 2023
@im2nguyen im2nguyen reopened this Nov 1, 2023
@hc-github-team-consul-core
Copy link
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@hc-github-team-consul-core
Copy link
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@trujillo-adam
Copy link
Contributor

Will manually backport instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@trujillo-adam trujillo-adam Awaiting requested review from trujillo-adam

Assignees

@trujillo-adam trujillo-adam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-consul-core @trujillo-adam @github-team-consul-core-pr-approver @im2nguyen