Backport of test: fix some of the peering topology tests to safely run without tenancy in CE into release/1.17.x #19543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/rboyer/fix-peering-topo-tests-for-tenancy/urgently-first-loon
branch
from
a4b0c35 to
b830cfd
Compare
hc-github-team-consul-core
force-pushed
the
backport/rboyer/fix-peering-topo-tests-for-tenancy/urgently-first-loon
branch
from
c53d61e to
e1c14e4
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 7, 2023
hc-github-team-consul-core
deleted the
backport/rboyer/fix-peering-topo-tests-for-tenancy/urgently-first-loon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19540 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
#19504 promoted some tests authored in enterprise to also run in CE. Since they were not running in both variations a few places were still passing non-empty tenancy fields which does not work in v1.
Additionally these test failures were missed before that PR was merged because these tests are only run nightly.
Overview of commits