-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update templated nomad policies #21872
base: main
Are you sure you want to change the base?
Update templated nomad policies #21872
Conversation
c1bd646
to
af26f0e
Compare
@@ -2,7 +2,7 @@ agent_prefix "" { | |||
policy = "read" | |||
} | |||
node_prefix "" { | |||
policy = "read" | |||
policy = "write" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanmorgan Does Nomad register nodes into Consul? I thought it only registered services to existing Consul nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is from:
since Consul 1.15 Nomad agents require a node:write policy, and not node:read like our documentation suggests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
References from the pr minimal Consul policy for Nomad agents needs node:write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated policy to limit changes to the named node.
@@ -1,10 +1,12 @@ | |||
|
|||
acl = "write" | |||
acl = "write" | |||
mesh = "write" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do Nomad servers need the mesh:write
permission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from https://developer.hashicorp.com/nomad/docs/integrations/consul/acl#nomad-agents
Nomad servers also create configuration entries for Consul Service Mesh, so the specific permissions vary slightly between Nomad servers and clients.
87c87db
to
c5dffcc
Compare
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
0eb8dca
to
1ba81be
Compare
Description
Updated the templated polices to match the recommended in the docs.
Links
https://developer.hashicorp.com/nomad/docs/integrations/consul/acl#nomad-agents
hashicorp/nomad#23802
PR Checklist