Fixes #4483: Add support for Authorization: Bearer token Header #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* appended Authorization header token parsing after X-Consul-Token * added test cases * updated website documentation to mention Authorization header
* improve tests * improve Bearer parsing
Added Authorization Bearer token support as per RFC6750
mbag
changed the title
|
Thanks @mbag. By description I was talking about the block of text where you said that the PR was related to the issue. Turns out I can just edit the description myself so I did. |
|
👍 OK. Now I know for the future PRs :) |
This was referenced Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4483
We tried to make Authorization Bearer header compliant with RFC6750 and other OAuth RFCs where appropriate. RFCs are referenced in comments.
Tests and documentation were added/updated as well.