ACL V2 CRUD RPC testing #4815
Merged
ACL V2 CRUD RPC testing #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
approved these changes
Oct 18, 2018
mkeeler
pushed a commit
that referenced
this pull request
Oct 19, 2018
This just fills in test coverage for CRUD operations against the new ACL RPC endpoints. 1 test is failing, `TestACLEndpoint_PolicyResolve`, but not sure if it may be an underlying issue in token assignment. Still some TODO in testing various cases outlined in #4791 but figured I'd put this up now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just fills in test coverage for CRUD operations against the new ACL RPC endpoints.
1 test is failing,
TestACLEndpoint_PolicyResolve, but not sure if it may be an underlying issue in token assignment.Still some TODO in testing various cases outlined in #4791 but figured I'd put this up now.