Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the MapWalk function so that it properly handles nested map[interface{}]interface{} #5774

Merged
merged 3 commits into from
May 2, 2019

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented May 2, 2019

Fixes #5746

mkeeler-corp:~ mkeeler$ cat proxy.json
{
   "Kind": "proxy-defaults",
   "Name": "global",
   "Config": {
      "nested": {
         "foo": "bar"
      }
   }
}
mkeeler-corp:~ mkeeler$ curl -XPUT localhost:8500/v1/config -d @proxy.json
true
mkeeler-corp:~ mkeeler$ consul config read -kind proxy-defaults -name global
{
    "Kind": "proxy-defaults",
    "Name": "global",
    "Config": {
        "nested": {
            "foo": "bar"
        }
    },
    "CreateIndex": 11,
    "ModifyIndex": 23
}

This fixes the JSON serialization errors with map[interface{}]interface{}

@mkeeler mkeeler added this to the 1.5.0 milestone May 2, 2019
@mkeeler mkeeler requested a review from a team May 2, 2019 17:09
mkeeler and others added 2 commits May 2, 2019 13:23
Lesson Learned: Don’t do conflict resolution in GitHub.
@mkeeler mkeeler merged commit 0ac6b6f into master May 2, 2019
@mkeeler mkeeler deleted the map-value-update branch May 2, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralized Config Proxy Defaults dont support nested maps
2 participants