Ensure the mesh gateway configuration comes back in the api within each upstream #6093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
reviewed
Jul 10, 2019
| } | ||
|
|
||
| // if the default mode | ||
| if meshGateway == structs.MeshGatewayModeDefault { | ||
| meshGateway = s.proxyCfg.MeshGateway.Mode | ||
| meshGateway = structs.MeshGatewayModeNone |
There was a problem hiding this comment.
Perhaps a test for this behavior you modified in the proxycfg package would be good.
banks
requested changes
Jul 12, 2019
banks
approved these changes
Jul 12, 2019
banks
approved these changes
Jul 12, 2019
rboyer
reviewed
Jul 12, 2019
rboyer
reviewed
Jul 12, 2019
rboyer
reviewed
Jul 12, 2019
rboyer
reviewed
Jul 12, 2019
Also start implementing proxycfg state testing.
mkeeler
force-pushed
the
bugfix/agent-api-upstream-gateway-config
branch
from
0bb6919 to
885646f
Compare
…rgets of a discovery chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6085
• Fixes the ToAPI method on the Upstream to properly convert the MeshGatewayConfig so it doesn't get returned as empty.
• Fixes a service dump kind blocking issue that caused it not to wake up the watcher when a service of that kind was deleted (or its check/node were deleted)
• Fixes another issue that caused mesh gateways to be used even for dc local connections.