Envoy CLI bind addresses #6107
Merged
Envoy CLI bind addresses #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddygv
reviewed
Jul 10, 2019
lkysow
reviewed
Jul 11, 2019
lkysow
approved these changes
Jul 11, 2019
banks
approved these changes
Jul 12, 2019
… structs This gets rid of some json encoder errors in the catalog endpoints
Any place where this struct gets JSON encoded will benefit as opposed to having to implement it everywhere.
Co-Authored-By: Paul Banks <[email protected]>
mkeeler
force-pushed
the
envoy-cli-bind-addresses
branch
from
626efd9 to
46d55c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the lan address was non-empty we would add the option to bind to the tagged addresses. Now that is only done if both the lan and wan addr are valid addresses of one of the hosts interfaces.
Additionally a new cli option
-bind-addresscan be used (multiple times) to create a mapping of the desired bind addresses to use instead of the default rules or tagged addresses. Therefore you can now advertise a service address (lan / wan) that are not necessarily real addresses of the container/system/etc. and then override the bind behavior.This is particularly useful for k8s to be able to use a load balancer where the IP is not known prior to registration and its not an address attached to one of the containers NICs.
In testing this I also found that some of our API responses were blowing up due to not being able to encode the proxy config with a nested map. So I added JSON serializer for the
ConnectProxyConfigstruct to ensure that the opaque config is JSON serializable.