ui: [Bugfix] Fix DC switching when blocking queries are enabled #6555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 26, 2019 14:26
We recently added a way to reconcile the ember data store when data was deleted in the backend and the data was kept hanging around in the frontend, only this didn't take into account different datacenters! This fix adds a 'fake' `x-consul-datacenter` header which then is converted to a meta value which we can access whilst doing this reconciliation. Now we can check the datacenter also before deciding whether to delete the record from our local cache.
As a result of this fix we added an new property to the meta values everywhere. This updates our integration response comparision assertions to look for that also.
johncowen
added
theme/ui
johncowen
pushed a commit
that referenced
this pull request
Nov 18, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
johncowen
added a commit
that referenced
this pull request
Nov 19, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
johncowen
added a commit
that referenced
this pull request
Nov 26, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
johncowen
added a commit
that referenced
this pull request
Dec 4, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
johncowen
added a commit
that referenced
this pull request
Dec 11, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
johncowen
added a commit
that referenced
this pull request
Dec 12, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
johncowen
added a commit
that referenced
this pull request
Dec 17, 2019
This is the same fix as #6555 but for the 1.7 version of the UI with additional nspace support
|
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6554
We recently added a way to reconcile the ember data store when data was
deleted in the backend and the data was kept hanging around in the
frontend, only this didn't take into account different datacenters!
This fix adds a 'fake'
x-consul-datacenterheader which then isconverted to a meta value which we can access whilst doing this
reconciliation. Now we can check the datacenter also before deciding
whether to delete the record from our local cache.
Tests included.
Quick note here this will have to be fixed differently for 1.7 as we have completely updated the Consul UI data layer there. The fix will be the same, just done in different places.
Thanks for the spot @eveld !