Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default of HTTPMaxConnsPerClient to 200 #7289

Merged
merged 1 commit into from
Feb 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent/config/default.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func DefaultSource() Source {
recursor_timeout = "2s"
}
limits = {
http_max_conns_per_client = 100
http_max_conns_per_client = 200
https_handshake_timeout = "5s"
rpc_handshake_timeout = "5s"
rpc_rate = -1
Expand Down
2 changes: 1 addition & 1 deletion agent/config/runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ type RuntimeConfig struct {
// HTTPMaxConnsPerClient limits the number of concurrent TCP connections the
// HTTP(S) server will accept from any single source IP address.
//
// hcl: limits{ http_max_conns_per_client = 100 }
// hcl: limits{ http_max_conns_per_client = 200 }
HTTPMaxConnsPerClient int

// HTTPSHandshakeTimeout is the time allowed for HTTPS client to complete the
Expand Down
2 changes: 1 addition & 1 deletion agent/config/runtime_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3466,7 +3466,7 @@ func TestConfigFlagsAndEdgecases(t *testing.T) {
// intentional.
rt.RPCHandshakeTimeout = 5 * time.Second
rt.HTTPSHandshakeTimeout = 5 * time.Second
rt.HTTPMaxConnsPerClient = 100
rt.HTTPMaxConnsPerClient = 200
rt.RPCMaxConnsPerClient = 100
},
},
Expand Down
2 changes: 1 addition & 1 deletion website/source/docs/agent/options.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -1397,7 +1397,7 @@ Valid time units are 'ns', 'us' (or 'µs'), 'ms', 's', 'm', 'h'."
Configures a limit of how many concurrent TCP connections a single
client IP address is allowed to open to the agent's HTTP(S) server. This
affects the HTTP(S) servers in both client and server agents. Default
value is `100`.
value is `200`.
* <a name="https_handshake_timeout"></a><a
href="#https_handshake_timeout">`https_handshake_timeout`</a> -
Configures the limit for how long the HTTPS server in both client and
Expand Down