Added unit test to ensure watches are not re-triggered on consul reload #7449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
from
6bf7a7c to
3560258
Compare
agent/agent_endpoint_test.go
Outdated
| tmpFileRaw, err := ioutil.TempFile("", "rexec") | ||
| if err != nil { | ||
| t.Fatalf("failed to make tmp file: %#v", err) | ||
| } |
There was a problem hiding this comment.
defer os.Remove(tmpFileRaw)
There was a problem hiding this comment.
if does no take a file descriptor, only a path: https://golang.org/pkg/os/#Remove, so I think I am correct
agent/agent_endpoint_test.go
Outdated
| dc1 := "dc1" | ||
| checkInterval := "1s" // This value ensure we could detect as transient critical state | ||
| tmpFileRaw, err := ioutil.TempFile("", "rexec") | ||
| if err != nil { |
There was a problem hiding this comment.
opt: these can be require.NoError(t, err)
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
2 times, most recently
from
ec77f48 to
892e23b
Compare
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
2 times, most recently
from
c33b3cc to
6986079
Compare
|
damned unstable integration tests |
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
3 times, most recently
from
dbbc930 to
ade8d53
Compare
This ensures no regression about hashicorp#7318 And ensure that hashicorp#7446 cannot happen anymore
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
from
ade8d53 to
9d1b832
Compare
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
3 times, most recently
from
0a4fcc9 to
52ec09e
Compare
pierresouchay
force-pushed
the
unit_test_for_watch_with_agent_reload
branch
from
52ec09e to
c14cfda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures no regression about #7318
And ensure that #7446 cannot happen anymore