Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t pass -u to get get inside Go build image dockerfile #7455

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Don’t pass -u to get get inside Go build image dockerfile #7455

merged 1 commit into from
Mar 16, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Mar 16, 2020

The -u was causing issues where it attempted to get newer versions of some modules than was linked in the tools go.mod file which no longer compiled.

@mkeeler mkeeler added this to the 1.7.x milestone Mar 16, 2020
@mkeeler mkeeler requested a review from a team March 16, 2020 18:59
hanshasselberg
hanshasselberg approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkeeler mkeeler merged commit 646c9f5 into master Mar 16, 2020
@mkeeler mkeeler deleted the bugfix/go-build-container-deps branch March 16, 2020 19:26
hashicorp-ci pushed a commit that referenced this pull request Mar 16, 2020
@mkeeler @hashicorp-ci
Don’t pass -u to get get inside Go build image dockerfile (#7455)
1a27255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mkeeler @hanshasselberg