Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that token clone copies the roles #7577

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Ensure that token clone copies the roles #7577

merged 1 commit into from
Apr 2, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Apr 2, 2020

Fixes #7576

Also modified the test to ensure policies, roles and service identities are all set in the initial token and present in the cloned token.

@mkeeler mkeeler added this to the 1.7.x milestone Apr 2, 2020
@mkeeler mkeeler requested a review from a team April 2, 2020 15:35
@mkeeler mkeeler changed the title Ensure that token clong copies the roles Ensure that token clone copies the roles Apr 2, 2020
crhino
crhino approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@crhino crhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler mkeeler merged commit 8aec09a into master Apr 2, 2020
@mkeeler mkeeler deleted the bugfix/token-clone-roles branch April 2, 2020 16:09
hashicorp-ci pushed a commit that referenced this pull request Apr 2, 2020
@mkeeler @hashicorp-ci
Ensure that token clone copies the roles (#7577)
b4191c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crhino crhino crhino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.x
Development

Successfully merging this pull request may close these issues.

ACL Token Cloning does not copy over the Roles
2 participants
@mkeeler @crhino